From 64fde73b159be3abcf8bb3fa7817a904125eb0c8 Mon Sep 17 00:00:00 2001
From: Fengzhe Zhou <zfz-960727@163.com>
Date: Tue, 12 Mar 2024 11:51:39 +0800
Subject: [PATCH] [Fix] Use logger.error on failure (#960)

---
 opencompass/runners/local.py            | 2 +-
 opencompass/runners/local_api.py        | 2 +-
 opencompass/runners/slurm.py            | 2 +-
 opencompass/runners/slurm_sequential.py | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/opencompass/runners/local.py b/opencompass/runners/local.py
index 35f3928a..a3194d5a 100644
--- a/opencompass/runners/local.py
+++ b/opencompass/runners/local.py
@@ -189,7 +189,7 @@ class LocalRunner(BaseRunner):
                                     stderr=stdout)
 
             if result.returncode != 0:
-                logger.warning(f'task {task_name} fail, see\n{out_path}')
+                logger.error(f'task {task_name} fail, see\n{out_path}')
         finally:
             # Clean up
             os.remove(param_file)
diff --git a/opencompass/runners/local_api.py b/opencompass/runners/local_api.py
index 253075f0..24874423 100644
--- a/opencompass/runners/local_api.py
+++ b/opencompass/runners/local_api.py
@@ -128,7 +128,7 @@ def launch(task: BaseTask, tokens: SyncManager.Semaphore):
         traceback.print_exc()
         # reset stdout and stderr
         reset_std()
-        logger.warning(f'task {task_name} fail, see\n{out_path}')
+        logger.error(f'task {task_name} fail, see\n{out_path}')
         returncode = 1
     else:
         # reset stdout and stderr
diff --git a/opencompass/runners/slurm.py b/opencompass/runners/slurm.py
index 26cb1ac6..e882a4c9 100644
--- a/opencompass/runners/slurm.py
+++ b/opencompass/runners/slurm.py
@@ -151,7 +151,7 @@ class SlurmRunner(BaseRunner):
                                         stderr=stdout)
 
             if result.returncode != 0 and not self.debug:
-                logger.warning(f'task {task_name} fail, see\n{out_path}')
+                logger.error(f'task {task_name} fail, see\n{out_path}')
         finally:
             # Clean up
             os.remove(param_file)
diff --git a/opencompass/runners/slurm_sequential.py b/opencompass/runners/slurm_sequential.py
index ad10eb5b..3b4dcad5 100644
--- a/opencompass/runners/slurm_sequential.py
+++ b/opencompass/runners/slurm_sequential.py
@@ -242,7 +242,7 @@ class SlurmSequentialRunner(BaseRunner):
                             retry -= 1
                             cmd = get_cmd()
                         else:
-                            logger.warning(
+                            logger.error(
                                 f'task {task_name} fail, see\n{out_path}')
                             break
                     else: